Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flying scoutsman game mode is not supported #2

Open
IncPlusPlus opened this issue Nov 17, 2020 · 0 comments
Open

Flying scoutsman game mode is not supported #2

IncPlusPlus opened this issue Nov 17, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@IncPlusPlus
Copy link
Owner

At the moment, flying scoutsman is called "casual" because it has a game_mode and game_type of 0 (same as casual). This means that the demo helper gets the name wrong if you're in a flying scoutsman match. This isn't too big of a deal to me. If I were to try and solve this, I might try and add a check in DemoRecordingHelper.handleStartRecord() where if the game mode string is "casual" check if the map is a map that is typically played in casual or flying scoutsman.

This is a low priority issue. If you record demos of flying scoutsman (scoutzknivez) and want it to be supported, react to this issue with a thumbs up. If I see enough people wanting it, I'll do it.

@IncPlusPlus IncPlusPlus self-assigned this Nov 17, 2020
@IncPlusPlus IncPlusPlus added this to the Future milestone Dec 12, 2020
@IncPlusPlus IncPlusPlus added the enhancement New feature or request label Jan 2, 2021
@IncPlusPlus IncPlusPlus modified the milestones: Future, 1.2.0 Jan 17, 2021
@IncPlusPlus IncPlusPlus added the help wanted Extra attention is needed label Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant