Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The id value of the form should be more specific #12

Open
kostasx opened this issue Dec 23, 2023 · 3 comments
Open

The id value of the form should be more specific #12

kostasx opened this issue Dec 23, 2023 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@kostasx
Copy link
Collaborator

kostasx commented Dec 23, 2023

<form id="form">

The name "form" is way too generic for an id. What is this form all about? Find an id that better describes the form's function and role.

@kostasx kostasx added the invalid This doesn't seem right label Dec 23, 2023
@leonalkalai
Copy link
Collaborator

Would an id "getBooks" be more suitable for this form that gets book?

@kostasx
Copy link
Collaborator Author

kostasx commented Dec 29, 2023

No, getBooks is a verb and implies action. Something like getBooks should preferrably be reserved for the function handling such actions, e.g. form.addEventListener("submit"). Something like "book-search" should be more appropriate for the form ID.

@leonalkalai
Copy link
Collaborator

@saligaros can you change the form id to "book-search" please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants