Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Basis selection for ODE Integrator in Splitting Cases #15

Open
bornhoft opened this issue Jul 23, 2021 · 0 comments
Open

Issue: Basis selection for ODE Integrator in Splitting Cases #15

bornhoft opened this issue Jul 23, 2021 · 0 comments
Labels
question Further information is requested style Doesn't seem to be the best implementation

Comments

@bornhoft
Copy link
Collaborator

When we solve the dU_q/dt = S(U_q) system of ODEs for splitting cases we are assuming that an orthogonal basis has been utilized allowing us to directly solve this equation in an uncoupled manner. In practice, this seems to work ok for non-orthogonal basis (like Lagrange) but there is likely errors being introduced because we haven't first projected onto an orthogonal basis first. This needs to be addressed at some point or a flag needs to be added to not allow non-orthogonal basis with splitting operations.

@bornhoft bornhoft added question Further information is requested style Doesn't seem to be the best implementation labels Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested style Doesn't seem to be the best implementation
Projects
None yet
Development

No branches or pull requests

1 participant