Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invA function in linear_algebra.h library is not general (i.e. no pivoting) #1

Open
bornhoft opened this issue Mar 31, 2022 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@bornhoft
Copy link
Contributor

Expected Behavior

Supposed to provide the inverse of a general square matrix.

Actual Behavior

Doesn't work for pivoting matrices

Steps to Reproduce the Problem

  1. Run the quad_2x2 example test case and print the Jacobian inside of the get_element_jacobian functions

Ideas to Fix

  1. Implement a general QR decomposition using Kokkos Kernels (see test_linear_algebra.cpp -> test_batched_math_inv_2x2_offdiagonal_QR). The issue with adding this is it requires additional working views (both vectors / matrices) that need to be preallocated on the GPU.

  2. For now, we can add analytic inverse matrices for 2x2 and 3x3 matrices (may be the best long term solution for the jacobian).

@bornhoft bornhoft added the invalid This doesn't seem right label Mar 31, 2022
@bornhoft bornhoft self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant