Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot prune unused images #31

Closed
bonotake opened this issue Feb 7, 2019 · 2 comments
Closed

Cannot prune unused images #31

bonotake opened this issue Feb 7, 2019 · 2 comments

Comments

@bonotake
Copy link
Contributor

bonotake commented Feb 7, 2019

Docker::prune_images() is not working now. When I called it, message Invalid filter 'filters' appeared.

As noted in #21, it runs on the latest API version (regarding mine, v1.39) where the filters parameter is gone.
This may be solved by solving #21, or deleting the following lines:
https://github.com/eldesh/dockworker/blob/a2fb30e6d93035a48dcf4607551b8219cc75b57e/src/docker.rs#L710-L713
bonotake added a commit to bonotake/dockworker that referenced this issue Feb 7, 2019
@bonotake
workaround to avoid eldesh/dockworker's Issue Idein#21, Idein#31
9b104bc
@bonotake
Copy link
Contributor Author

bonotake commented Feb 7, 2019

I was wrong. v1.39 has filters parameter exists as well as v1.26.
https://docs.docker.com/engine/api/v1.39/#operation/ImagePrune
https://docs.docker.com/engine/api/v1.26/#operation/ImagePrune

So I suspect the JSON value has something wrong, but I don't understand how to fix it.

@bonotake bonotake mentioned this issue Feb 7, 2019
Merged
@eldesh
Copy link
Collaborator

eldesh commented Feb 15, 2019

fixed with #32

@eldesh eldesh closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eldesh @bonotake