New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed strings for translations #21

Closed

ITotalJustice opened this issue Dec 17, 2024 · 2 comments

Owner

ITotalJustice commented Dec 17, 2024

see #19

Contributor

Yorunokyujitsu commented Dec 19, 2024

I gathered and organized the missing strings in lang.json by section.
And translated Korean and Japanese, and it seems to be working.
https://github.com/Yorunokyujitsu/sphaira/blob/test/assets/romfs/i18n/ko.json
https://github.com/Yorunokyujitsu/sphaira/blob/test/assets/romfs/i18n/ja.json

The string in the Homebrew Delete message box is too long, so I changed it to show only the path.
https://github.com/Yorunokyujitsu/sphaira/blob/test/sphaira/source/ui/menus/homebrew.cpp#L102

Yorunokyujitsu@9f9936f

Owner Author

ITotalJustice commented Dec 21, 2024

fixed in #32

ITotalJustice closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment