Add Python 3.13 to the workflow matrix #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oerc0122 For now I just extended the existing lists of Python versions. Does it make sense to keep multiple versions in |
|
If it's pure Python, you shouldn't need variant wheels. I recommend keeping the CIBW style around as at some point there is a suggestion of C++/Rust acceleration, but I suspect we can get away without multiple builds. The question is, do we have tests for the PyPI pushed versions, and do we want some? Euphonic has some examples we might |
oerc0122
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Python 3.13 seems to provide all our dependencies now. This PR adds Python 3.13 to the workflows.
closes #614
Fixes
Added 3.13 to the list of Python versions on which we run the workflows.
To test
All tests should pass.