Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed discover fold setting #645

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

ChiCheng45
Copy link
Collaborator

Description of work
Previously the Discover converter always folded the trajectory whether or not the setting had been selected.

Fixes
The discover converter fold setting.

To test
Run the discover converter job and check that the fold setting works correctly.

@ChiCheng45 ChiCheng45 self-assigned this Jan 28, 2025
Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The fold setting now makes a difference.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 2d61189 into protos Jan 28, 2025
28 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the chi/disocover-folding-fix branch January 28, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants