Modernise strings #643
Merged
Modernise strings #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
force-pushed
the
modernise-strings
branch
7 times, most recently
from
692fe0f to
560ed94
Compare
oerc0122
force-pushed
the
modernise-strings
branch
2 times, most recently
from
3e1b880 to
c0e045b
Compare
oerc0122
force-pushed
the
modernise-strings
branch
2 times, most recently
from
e005f49 to
600025f
Compare
MBartkowiakSTFC
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Standardise strings to modern f-string style.
Fixes
Major changes in:
MDANSE/Src/MDANSE/Chemistry/Databases.py:info- Table formatting methodMDANSE/Src/MDANSE/Framework/Configurable.py:build_doc_texttable- Table formatting methodMDANSE/Src/MDANSE/Framework/Converters/Discover.py/MDANSE/Src/MDANSE/Framework/Converters/Forcite.py- Binary parsers struct syntax.MDANSE/Src/MDANSE/Framework/Jobs/*- Addpair_str = "".join(map(str, pair))(andinv_pair_str) to replace e.g.'f(q,t)_%s%s' % pairMDANSE/Src/MDANSE/Framework/Units.py:_Unit.__str__- Pos/Neg unit str handlingMDANSE/Src/MDANSE/Mathematics/Arithmetic.py- Reformat to dict comprehensionTo test
Nothing should change, standard tests should pass.