Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity interpolation order 0 fix #403

Merged
merged 8 commits into from
Apr 7, 2024
Merged

Conversation

ChiCheng45
Copy link
Collaborator

Description of work
Fixed temperature, DOS and vacf jobs so that they use velocities with order=0. Updated GUI so that the interpolation order choices go from 0-5. Order=0 is only available when velocity data is available. Order=0 is the default if available.

Fixes
Fixes #360

To test

  • Load up a trajectory without velocity data in the GUI and check that the possible values of the interpolations order is 1-5.
  • Check again but with a trajectory with velocity data. The interpolations order values choices should be 0-5. Defaults should be 0.
  • Run a job e.g. temperature with order=0. This should work with issues.

Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out on a few trajectories. Everything worked as expected.

@MBartkowiakSTFC MBartkowiakSTFC merged commit fd5b841 into protos Apr 7, 2024
84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the chi/velocity-fix branch April 7, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Velocity interpolation order 0 is not used
2 participants