-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic molecule labels from MoleculeFinder #392
Conversation
…to minimum-effort-atom-labels
…to minimum-effort-atom-labels
…to minimum-effort-atom-labels
…to minimum-effort-atom-labels
…to minimum-effort-atom-labels
Looks good but a few points. The angular correlation results can depend on whether it was run with a trajectory which had been modified with moleculefinder or not. This looks like it is because in some cases the coordinates are not contiguous so the results will be different. Maybe the atoms positions should be are changed to be contiguous during the calculation? Would it be a good idea to set the axis in the angular correlation to something physical since at the moment the results will depend the atom ordering. Maybe we can change it to the molecules axis of rotation and we'd then have angular correlation results for the three molecular axes. Molecular finder can crash when it is used with some bulk system like with the p1 cp2k system from MDANSE-Examples. I got the following error.
|
…to minimum-effort-atom-labels
I managed to address two of the points you raised:
Also, I improved the docstring of MoleculeFinder. |
Looks good, works on my end. I've open a proposal for some enhancements to molecule related jobs in #399 which include the axis proposal from my comment above. |
Description of work
Some analysis types (AreaPerMolecule, AngularCorrelation) require the molecules in the system to have labels in order to be selected. However, not every MD engine assigns labels to molecules.
Fixes
To test