Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes define genie python #212

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fixes define genie python #212

merged 1 commit into from
Nov 20, 2024

Conversation

jackbdoughty
Copy link
Contributor

Uses random instead of python build number as a directory to install python so that multiple python builds can be installed and used concurrently without permissions issues.

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Nov 20, 2024

Hi,

the other issue was that if the bat file was called passing an directory name with a space it then seemed LATEST_PYTHON_DIR_T was not propagated correctly that lead to it not totally working. Can you investigate improving the quoting on LATEST_PYTHON_DIR_T - it should be easy to confirm/test by calling define_latest_genie_python.bat "directory with spaces" it may be as simple as using "%LATEST_PYTHON_DIR_T%" to comamdns like mkdir etc. but may also need changes in remove_genie_python.bat

@jackbdoughty
Copy link
Contributor Author

Hi,

the other issue was that if the bat file was called passing an directory name with a space it then seemed LATEST_PYTHON_DIR_T was not propagated correctly that lead to it not totally working. Can you investigate improving the quoting on LATEST_PYTHON_DIR_T - it should be easy to confirm/test by calling define_latest_genie_python.bat "directory with spaces" it may be as simple as using "%LATEST_PYTHON_DIR_T%" to comamdns like mkdir etc. but may also need changes in remove_genie_python.bat

Had a look with Tom about this, looks like a deeper rooted issue involving the genie_python_install script so easier to rename the jenkins job atleast as a temporary solution.

@Chsudeepta Chsudeepta merged commit f8efe7d into master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants