Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used function "ggplot2::fortify" may be deprecated in the future #4

Open
capsizingHR opened this issue Jan 10, 2020 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@capsizingHR
Copy link
Member

In the function "theo_del" the ggplot2 function fortify is used to convert the data of a SptialPolygon to a data frame.

con <- ggplot2::fortify(sp_con)

According to the documentation the function fortify may be deprecated in the future.Mmaybe it should be replaced with the appropiate function from the 'broom' package as described by ggplot2 documentation. This works with warnings and 'group' is chr instead of factor but as only order is used, that is not a problem.

BUT: In the broom package documentation it is stated that development of sp tidiers is halted and may be deprecated in the future. They propose changing to sf instead of sp. That would effect the whole package here...

@capsizingHR capsizingHR added the enhancement New feature or request label Jan 10, 2020
@FFaupel
Copy link
Member

FFaupel commented Jan 13, 2020

Updating all functions to sf instead of sp is probably a good idea! Best to start right now, or? End of this month I have some extra time to work on such things.

@capsizingHR
Copy link
Member Author

capsizingHR commented Jan 13, 2020

While I also think that updating to sf, where already possible, is the best way for the future, the question is, if we shouldn't first finish the documentation of the package as it is now. But if you have time at the end of the month, we can certainly talk about it in detail! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants