From 72b2c1516f8ae1f67efeef27f2dcb55ae5894e1d Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Mon, 6 Dec 2021 13:20:30 +0200 Subject: [PATCH 1/2] Update README-developers.md --- README-developers.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README-developers.md b/README-developers.md index 781efdb7..b05879bf 100644 --- a/README-developers.md +++ b/README-developers.md @@ -127,17 +127,18 @@ log to determine if any modifications have been made? * Put the `master` branch in the state we want for release (i.e. merge any approved PR that we want included in that release, etc.). * Update the [constraits.txt file](https://github.com/INCATools/ontology-development-kit/pull/476#issuecomment-924050937) * Do any amount of testing as needed to be confident we are ready for release (at the very least, do a local build with `make build` and run the test suite with `make tests`; possibly run some mock releases on known ontologies such as `FBbt`, etc.). -* Tag the release and push the tag to GitHub. -* From GitHub, create a formal release from the newly pushed tag. This should automatically trigger the `build-multiarch.yml` GitHub Action, leading to both the x86_64 and arm64 images being built and published under the `obolibrary/` namespace. +* Tag the release and push the tag to GitHub and create a formal release from the newly pushed tag. +* Run `docker login` to ensure you are logged in. You must have access rights to `obolibrary` organisation to run the following. +* Run `make publish-multiarch` to publish the ODK in the `obolibrary` dockerhub organisation. -To then publish the multi-arch images under the `obotools/` namespace, we need to run locally: +If you want publish the multi-arch images under the `obotools/` organisation, you need to run locally: ```sh $ docker buildx create --name multiarch --driver docker-container --use $ make publish-multiarch IM=obotools/odkfull IMLITE=obotools/odklite DEV=obotools/odkdev ``` -(The first command only being needed when you attempt a multi-arch build for the first time. Its effects are persistent, so it will never be needed again for any subsequent release — unless you completely reset your Docker installation in the meantime.) +The first command only being needed when you attempt a multi-arch build for the first time. Its effects are persistent, so it will never be needed again for any subsequent release — unless you completely reset your Docker installation in the meantime. More details below. From b8496fdcc9af75c7d1d7cd391bef73c2fbdd8c81 Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Mon, 6 Dec 2021 13:31:47 +0200 Subject: [PATCH 2/2] Update README-developers.md --- README-developers.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README-developers.md b/README-developers.md index b05879bf..173148b1 100644 --- a/README-developers.md +++ b/README-developers.md @@ -129,6 +129,7 @@ log to determine if any modifications have been made? * Do any amount of testing as needed to be confident we are ready for release (at the very least, do a local build with `make build` and run the test suite with `make tests`; possibly run some mock releases on known ontologies such as `FBbt`, etc.). * Tag the release and push the tag to GitHub and create a formal release from the newly pushed tag. * Run `docker login` to ensure you are logged in. You must have access rights to `obolibrary` organisation to run the following. +* Run `docker buildx create --name multiarch --driver docker-container --use` if you have not done so in the past. This command needs to be run only once, see below. * Run `make publish-multiarch` to publish the ODK in the `obolibrary` dockerhub organisation. If you want publish the multi-arch images under the `obotools/` organisation, you need to run locally: @@ -138,7 +139,7 @@ $ docker buildx create --name multiarch --driver docker-container --use $ make publish-multiarch IM=obotools/odkfull IMLITE=obotools/odklite DEV=obotools/odkdev ``` -The first command only being needed when you attempt a multi-arch build for the first time. Its effects are persistent, so it will never be needed again for any subsequent release — unless you completely reset your Docker installation in the meantime. +Same as before, the first command (`docker buildx create..`) only being needed when you attempt a multi-arch build for the first time. Its effects are persistent, so it will never be needed again for any subsequent release — unless you completely reset your Docker installation in the meantime. More details below.