Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty thumbnail and logo get validated successfully #167

Open
martimpassos opened this issue Jul 13, 2023 · 0 comments
Open

Faulty thumbnail and logo get validated successfully #167

martimpassos opened this issue Jul 13, 2023 · 0 comments

Comments

@martimpassos
Copy link

martimpassos commented Jul 13, 2023

A bug in my code was creating incorrect properties and values for image resources, but this didn't come up while validating the manifest.

Here's a manifest to reproduce the issue, note the thumbnail type and set_width, set_height props:

{
  "@context": "http://iiif.io/api/presentation/3/context.json",
  "id": "https://iiif.imaginerio.org/iiif/34163000/manifest.json",
  "type": "Manifest",
  "label": {
    "pt-BR": [
      "Centro da cidade a partir do Morro do Castelo"
    ]
  },
  "metadata": [
    {
      "label": {
        "en": [
          "Document ID"
        ],
        "pt-BR": [
          "Identificador"
        ]
      },
      "value": {
        "none": [
          "007_IMG_3555"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Creator"
        ],
        "pt-BR": [
          "Criador"
        ]
      },
      "value": {
        "en": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q3180571\">Marc Ferrez</a>"
        ],
        "pt-BR": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q3180571\">Marc Ferrez</a>"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Date"
        ],
        "pt-BR": [
          "Data"
        ]
      },
      "value": {
        "none": [
          "circa 1914"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Type"
        ],
        "pt-BR": [
          "Tipo"
        ]
      },
      "value": {
        "en": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q125191\">Photograph</a>",
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q35158\">Stereoscopy</a>"
        ],
        "pt-BR": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q125191\">Fotografia</a>",
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q35158\">Estereoscopia</a>"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Material"
        ],
        "pt-BR": [
          "Material"
        ]
      },
      "value": {
        "en": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q97570383\">Glass Diapositive</a>"
        ],
        "pt-BR": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q97570383\">Diapositivo de vidro</a>"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Fabrication Method"
        ],
        "pt-BR": [
          "Método de Fabricação"
        ]
      },
      "value": {
        "en": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q355674\">Autochrome Process</a>"
        ],
        "pt-BR": [
          "<a class=\"uri-value-link\" target=\"_blank\" href=\"http://wikidata.org/wiki/Q355674\">Autocromo</a>"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Width (mm)"
        ],
        "pt-BR": [
          "Largura (mm)"
        ]
      },
      "value": {
        "none": [
          "65.0"
        ]
      }
    },
    {
      "label": {
        "en": [
          "Height (mm)"
        ],
        "pt-BR": [
          "Altura (mm)"
        ]
      },
      "value": {
        "none": [
          "60.0"
        ]
      }
    }
  ],
  "requiredStatement": {
    "label": {
      "en": [
        "Attribution"
      ],
      "pt-BR": [
        "Atribuição"
      ]
    },
    "value": {
      "en": [
        "Provided by Instituto Moreira Salles. Hosted by imagineRio."
      ],
      "pt-BR": [
        "Disponibilizado por Instituto Moreira Salles. Hospedado por imagineRio."
      ]
    }
  },
  "rights": "http://rightsstatements.org/vocab/CNE/1.0/",
  "thumbnail": [
    {
      "id": "https://iiif.imaginerio.org/iiif/34163000/full/517,473/0/default.jpg",
      "type": "thumbnail",
      "set_width": 517,
      "set_height": 473
    }
  ],
  "seeAlso": [
    {
      "id": "https://www.imaginerio.org/map#34163000",
      "type": "Text",
      "label": {
        "none": [
          "imagineRio"
        ]
      }
    },
    {
      "id": "https://iiif.imaginerio.org/iiif/34163000/full/max/0/default.jpg",
      "type": "Text",
      "label": {
        "en": [
          "Download image"
        ],
        "pt-BR": [
          "Baixar imagem"
        ]
      }
    }
  ],
  "homepage": [
    {
      "id": "http://acervos.ims.com.br/portals/#/detailpage/107775",
      "type": "Text",
      "label": {
        "none": [
          "Instituto Moreira Salles"
        ]
      },
      "format": "text/html"
    }
  ],
  "provider": [
    {
      "id": "https://imaginerio.org/",
      "type": "Agent",
      "label": {
        "en": [
          "imagineRio"
        ],
        "pt-BR": [
          "imagineRio"
        ]
      },
      "homepage": [
        {
          "id": "http://acervos.ims.com.br/portals/#/detailpage/107775",
          "type": "Text",
          "label": {
            "none": [
              "Instituto Moreira Salles"
            ]
          },
          "format": "text/html"
        }
      ],
      "logo": [
        {
          "id": "https://aws1.discourse-cdn.com/free1/uploads/imaginerio/original/1X/8c4f71106b4c8191ffdcafb4edeedb6f6f58b482.png",
          "type": "Image",
          "format": "image/png",
          "set_width": 708,
          "set_height": 164
        }
      ]
    }
  ],
  "items": [
    {
      "id": "https://iiif.imaginerio.org/iiif/canvas/p1",
      "type": "Canvas",
      "label": {
        "none": [
          "34163000"
        ]
      },
      "height": 7572,
      "width": 8280,
      "items": [
        {
          "id": "https://iiif.imaginerio.org/iiif/annotation-page/p1",
          "type": "AnnotationPage",
          "items": [
            {
              "id": "https://iiif.imaginerio.org/iiif/annotation/p1",
              "type": "Annotation",
              "motivation": "painting",
              "body": {
                "id": "https://iiif.imaginerio.org/iiif/34163000/full/max/0/default.jpg",
                "type": "Image",
                "format": "image/jpeg",
                "height": 7572,
                "width": 8280,
                "service": [
                  {
                    "id": "https://iiif.imaginerio.org/iiif/34163000",
                    "type": "ImageService3",
                    "profile": "level0"
                  }
                ]
              },
              "target": "https://iiif.imaginerio.org/iiif/canvas/p1"
            }
          ]
        }
      ]
    }
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant