Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug in CubicComplementarityVLE calculate_teq method #1560

Open
Mahakileach opened this issue Jan 21, 2025 · 0 comments
Open

Small bug in CubicComplementarityVLE calculate_teq method #1560

Mahakileach opened this issue Jan 21, 2025 · 0 comments
Assignees
@dallan-keylogic
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@Mahakileach
Copy link

Issue
Within idaes\models\properties\modular_properties\phase_equil\smooth_VLE_2.py the calculate_teq(blk, pp) method checks if v_only_comps is None. The implementation of identify_VL_component_list(blk, phase_pair) always returns a list and as such v_only_comps is None always evaluate to False.

Proposed fix
Replace v_only_comps is None with v_only_comps == [] or len(v_only_comps) == 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dallan-keylogic dallan-keylogic

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ksbeattie @Mahakileach @dallan-keylogic