Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping to use ubuntu2204 build of idaes-ext on Ubuntu 24.04 #1559

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Add mapping to use ubuntu2204 build of idaes-ext on Ubuntu 24.04 #1559

merged 10 commits into from
Feb 20, 2025
+21 −6

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

Try the easiest possible way to resolve #1557 and similar issues before new idaes-ext builds are available

Changes proposed in this PR:

  • Add mapping in idaes/config.py to use existing ubuntu2204 version if ubuntu2404 is detected
  • Add ubuntu22.04 and 24.04 to CI job matrix

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Jan 16, 2025
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jan 16, 2025
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Jan 16, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Jan 16, 2025
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review January 29, 2025 16:12
@lbianchi-lbl
Copy link
Contributor Author

These are the errors showing up in the ubuntu-24.04 runs:

image
image

image

@lbianchi-lbl
Copy link
Contributor Author

lbianchi-lbl commented Jan 30, 2025 •
edited
Loading

The IPOPT version parsing error might be considered part of Pyomo/pyomo#1030

@ksbeattie
Copy link
Member

ksbeattie commented Feb 6, 2025 •
edited
Loading

@lbianchi-lbl @jsiirola asks if we could get the output of running ipopt to better understand how Pyomo's parsing might be failing.

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 14, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (2182772) to head (490dd68).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
- Coverage   76.86%   76.86%   -0.01%     
==========================================
  Files         394      394              
  Lines       63233    63233              
  Branches    10355    10355              
==========================================
- Hits        48604    48601       -3     
- Misses      12184    12188       +4     
+ Partials     2445     2444       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ksbeattie
ksbeattie approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie requested a review from mrmundt February 20, 2025 19:40
@lbianchi-lbl lbianchi-lbl changed the title See if existing ubuntu2204 build of idaes-ext work at all on Ubuntu 24.04 Add mapping to use ubuntu2204 build of idaes-ext on Ubuntu 24.04 Feb 20, 2025
@ksbeattie ksbeattie enabled auto-merge (squash) February 20, 2025 19:51
@lbianchi-lbl lbianchi-lbl mentioned this pull request Feb 20, 2025
Open
@lbianchi-lbl lbianchi-lbl merged commit 90398a2 into IDAES:main Feb 20, 2025
63 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie

@adam-a-a adam-a-a

@mrmundt mrmundt

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: Pynumero not available due to Ubuntu 24.04 being unsupported by idaes get-extensions
6 participants
@lbianchi-lbl @ksbeattie @codecov-commenter @adam-a-a @mrmundt @idaes-build