From 1ab5dd37885480cccc2c0c2a2aad32cc9e728524 Mon Sep 17 00:00:00 2001 From: moralapablo Date: Tue, 30 Jan 2024 01:03:48 +0100 Subject: [PATCH] Solve rounding precision problems when testing in mac, bump patch version to 0.1.1 and update NEWS. --- DESCRIPTION | 2 +- NEWS.md | 4 ++++ cran-comments.md | 5 ++--- tests/testthat/test-nn2poly.R | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 9b1fea4..e762fef 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: nn2poly Title: Neural Network Weights Transformation into Polynomial Coefficients -Version: 0.1.0 +Version: 0.1.1 Authors@R: c( person(given = "Pablo", family = "Morala", role = c("aut", "cre"), email = "moralapablo@gmail.com", diff --git a/NEWS.md b/NEWS.md index a0b22c3..49eade3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# nn2poly 0.1.1 + +- Solve test rounding precision problem due to new architechture of mac OS (#69). + # nn2poly 0.1.0 - Initial release of the package. diff --git a/cran-comments.md b/cran-comments.md index 2ca4e75..50b433a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,7 +1,6 @@ -## Resubmission +## Patch release -1. Examples with unexported functions have been removed. -2. Examples using `\dontrun` are required as they use `keras` and `torch`, which require an interactive setup. +- Solve test rounding precision problem due to new architechture of mac OS. ## Test environments diff --git a/tests/testthat/test-nn2poly.R b/tests/testthat/test-nn2poly.R index 2f18756..fc811bf 100644 --- a/tests/testthat/test-nn2poly.R +++ b/tests/testthat/test-nn2poly.R @@ -50,7 +50,7 @@ test_that("nn2poly with list input against precomputed example with label <- result$labels[[4]] coeff <- result$values[4,1] expect_equal(label,c(1,1)) - expect_equal(round(coeff,4),-4.4295) + expect_equal(round(coeff,3),-4.429) })