Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolkit directory in the archive is undefined #50

Open
Kyrellos-Salib opened this issue May 24, 2019 · 0 comments
Open

toolkit directory in the archive is undefined #50

Kyrellos-Salib opened this issue May 24, 2019 · 0 comments
Assignees
@Kyrellos-Salib
Milestone
v0.5.0

Comments

@Kyrellos-Salib
Copy link

In the BuildSourceArchive function in source-archive-utils.js file, local toolkits gets added to the archive in the directory toolkits/${tk.tk} by the following line
toolkitPaths.forEach(tk => archive.directory(tk.tkPath, 'toolkits/${tk.tk}'));.
All the toolkits end up getting added to toolkits/undefined in the archive since tk has only the name and tkPath variables.

I think it can be fixed by changing tk.tk to tk.name.
@Kyrellos-Salib Kyrellos-Salib changed the title toolkit directory in the archive toolkit directory in the archive is undefined May 29, 2019
@guychris guychris added this to the v0.5.0 milestone Jul 17, 2019
guychris pushed a commit that referenced this issue Jul 18, 2019
@Kyrellos-Salib
Add unit tests and minor fixes (#51)
7896a08 
* The package will be able to read intervals for the toolkit dependencies from the info.xml file (ex: [2.0.0,3.0.0))

* Created 1 or more tests for most exported util functions and made minor fixes to some of them.

fix for #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kyrellos-Salib Kyrellos-Salib

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
2 participants
@guychris @Kyrellos-Salib