Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to open source Kubernetes Helm Charts so PRs can be merged #60

Open
some-ibmer opened this issue Jan 10, 2018 · 2 comments
Open

Comments

@some-ibmer
Copy link
Contributor

The open source helm charts are close to getting approval to merge. Each chart requires tests. I have added trivial tests to each that simply echo the name of the chart, but they need to be updated to be more substantial and ensure the network is functioning properly.

The charts have been reviewed many times; however, additional items are found each time that need to be corrected. Here are the PRs:

ibm-blockchain-network - helm/charts#2069
ibm-blockchain-channel - helm/charts#2070
ibm-blockchain-chaincode - helm/charts#2071

Despite having the trivial tests, the ibm-blockchain-channel and ibm-blockchain-chaincode chart tests cannot be found by the charts repo CI, so I’m not sure what’s going on there.

I have reflected these changes into the ibm-container-service repository so that they currently match; however, I cannot get the channel creation chart to succeed. I’ve spend days debugging it, but I can’t seem to figure out what’s going on. If either of you could take a look, that would be great.

@some-ibmer
Copy link
Contributor Author

some-ibmer commented Jan 10, 2018

@mrshah-at-ibm / @dhyey-ibm, I have been updating the helm charts in this repository and then copying them over to the charts repository.

PR #59 has my changes in it for this repository, but as you can see in the PR there are some issues with channel creation that I cannot get to the bottom of.

Once these issues are resolved, the PR should be merged and copied into the official PRs in the charts repository.

@mrshah-at-ibm / @dhyey-ibm, both of you should have access to my repository so that you can make updates to the three PRs. Each Chart for the charts repository has a branch, one chart per branch and they are as follows:

  • ibm-blockchain-network
  • ibm-blockchain-channel
  • ibm-blockchain-chaincode

Let me know if you have any questions.

@mrshah-at-ibm
Copy link

We have decided not to pursue this for now. We will get back to this if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants