Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-define source terms need access to ParameterInput #405

Open
jmstone opened this issue Dec 15, 2023 · 0 comments
Open

User-define source terms need access to ParameterInput #405

jmstone opened this issue Dec 15, 2023 · 0 comments

Comments

@jmstone
Copy link
Collaborator

jmstone commented Dec 15, 2023

In GitLab by @jmstone216 on Dec 15, 2023, 10:53

In implementing a new cooling function, Jake Rule pointer out that User-defined source terms have access to the Mesh pointer, but not to the instance of ParameterInput, which is needed for input parameters that are used in the source term. In Athena++ this is fixed by using UserVariables. However, this is a complicated solution, requiring functions to create, store, and name these variables. We need to implement a simple solution in AthenaK, either following the Athena++ example, passing in a pointer to the ParameterInput object, or some other idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant