Forbid visible day range to be within the working hours to prevent unwanted hidden events #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genglert
requested changes
Feb 20, 2025
creme/activities/forms/config.py
Outdated
| 'not be displayed' | ||
| ).format( | ||
| start=date_format(view_day_start, 'TIME_FORMAT'), | ||
| end=date_format(view_day_end, 'TIME_FORMAT'), |
There was a problem hiding this comment.
Are you sure "view_day_end" cannot be None here?
There was a problem hiding this comment.
Default is time(0, 0, 0) in database model. But in this case I wonder 🤔
creme/activities/forms/config.py
Outdated
| @@ -68,6 +68,35 @@ def clean(self, *args, **kwargs): | |||
| ) | |||
| ) | |||
|
|
|||
| if view_day_start != view_day_end: | |||
There was a problem hiding this comment.
Hum if start & end are "7pm", the range has a 0-duration (I presume it would be an issue), isn't it?
There was a problem hiding this comment.
if the range as 0-duration I assume that is a 24h duration. But an error if start & end are not the default values (00:00) could be a good idea.
There was a problem hiding this comment.
The same problem can happen for the working hours range too.
…wanted hidden events
joehybird
force-pushed
the
fix/calendar_view_range_validation
branch
from
f89c822 to
15a06e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.