Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the repository name to be lowercase in the custom docker workflow #6530

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Exairnous
Copy link
Contributor

@Exairnous Exairnous commented Feb 25, 2025

What?

Converts the repository name to lowercase before storing it as an environment variable for use when connecting to the docker repository.

Why?

Some (or possibly all?) container registries don't allow their repository names to be capitalized, but the workflow gets the docker repository name from the GitHub repository name (which is allowed to be capitalized), so if the GitHub repository name is capitalized, this can prevent the workflow from working.

How to test

Repository name with no uppercase letters:

  1. Push the changes to a branch on your personal GitHub repository.
  2. Run the custom-docker-build-push action/workflow on that branch. (Workflow docs)

Repository name with uppercase letters:

  1. Basically the same process as above, but use this pull request from the Spoke repository (which is capitalized): Add GitHub workflow file to build/tag/push custom docker images Spoke#1305

Converts the repository name to lowercase before storing it as an environment variable for use when connecting to the docker repository.

Some (or possibly all?) container registries don't allow their repository names to be capitalized, but the workflow gets the docker repository name from the GitHub repository name (which is allowed to be capitalized), so if the GitHub repository name is capitalized, this can prevent the workflow from working.
Copy link
Contributor

@DougReeder DougReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exairnous Exairnous merged commit 824fc13 into master Feb 25, 2025
5 checks passed
@Exairnous Exairnous deleted the custom-docker-workflow-force-lowercase-repo-name branch February 25, 2025 21:31
@Exairnous
Copy link
Contributor Author

Thanks. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants