Look for the holdable media root when grabbing an object #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
reviewed
Dec 1, 2023
| name="Image" | ||
| image={imageDef} | ||
| objectMenuTarget={{ isFlat: true }} | ||
| grabbable={{ cursor: true, hand: false }} |
There was a problem hiding this comment.
This looks like it's only grabbable for 2D users and not VR users. Is this intentional or am I missing something?
There was a problem hiding this comment.
We only want media loaded as spawned media to be hand grabbable (but we want them to be cursor interactable) so only the root media prefab is the one grabbable, not all scene media:
Is the same for the rest of the media loaders, load-pdf. load-video, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grabbing an object we want to look for the root media loader as that's the object that have a networked transform.
Related #6338