Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine whether we support anchors including multi-byte characters #432

Open
carlgieringer opened this issue Jun 25, 2023 · 0 comments
Open

Determine whether we support anchors including multi-byte characters #432

carlgieringer opened this issue Jun 25, 2023 · 0 comments
Labels
core domain Entities and core domain/business logic

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Jun 25, 2023 •
edited
Loading

The library we depend on doesn't appear to. So we should determine if our highlights including multi-byte characters (emoji, Chinese, etc.) work as intended.

tilgovi/dom-anchor-text-position#6

Could update to use the fork mentioned here? google/diff-match-patch#143 (comment)
@carlgieringer carlgieringer added the core domain Entities and core domain/business logic label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core domain Entities and core domain/business logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlgieringer