Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutesync: disable #199584

Merged
merged 1 commit into from
Jan 26, 2025
Merged

mutesync: disable #199584

merged 1 commit into from
Jan 26, 2025

Conversation

daeho-ro
Copy link
Member

NOTE: As of November 16, 2024 the physical mütesync mute button is supported via the MuteMe application. The mütesync app will no longer receive updates and will eventually be retired. We recommend downloading the MuteMe application to use your mütesync physical button. For more information, visit this page on the MuteMe website.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@daeho-ro
Copy link
Member Author

CI passes for muteme and mutesync should be syntax only, I think this will be enough to go and waiting for reviews :)

Casks/m/muteme.rb Outdated Show resolved Hide resolved
@khipp
Copy link
Member

khipp commented Jan 26, 2025

I think we should deprecate mutesync first. It seems there is some friction when switching:

No, all settings will need to be reconfigured in MuteMe. Since the apps manage settings differently and MuteMe includes additional options, we recommend taking note of your preferred configurations before switching.

@daeho-ro daeho-ro changed the title mutesync: disable, muteme 0.24.8 (new cask) mutesync: deprecate, muteme 0.24.8 (new cask) Jan 26, 2025
@BrewTestBot BrewTestBot removed the cask disabled Cask disabled label Jan 26, 2025
@khipp
Copy link
Member

khipp commented Jan 26, 2025

Downloading mutesync seems to no longer be possible, so we should disable the cask after all. My bad!

We should probably split the PR though, so we don't have to run ci-syntax-only for both.

@daeho-ro daeho-ro changed the title mutesync: deprecate, muteme 0.24.8 (new cask) mutesync: disable Jan 26, 2025
@daeho-ro daeho-ro mentioned this pull request Jan 26, 2025
8 tasks
@daeho-ro daeho-ro added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jan 26, 2025
Casks/m/mutesync.rb Outdated Show resolved Hide resolved
@khipp khipp merged commit ccd4f8f into master Jan 26, 2025
9 checks passed
@khipp khipp deleted the disable-mutesync branch January 26, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask disabled Cask disabled ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants