Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eset-cyber-security: use versioned url and update livecheck #199259

Conversation

zyoshoka
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 25, 2025
@bevanjkay
Copy link
Member

The pkg installer for eset-cyber-security-pro is failing specifically on ARM. I haven't tested locally.
Because the install doesn't complete, I imagine that the receipt isn't available for uninstall, which is why artifacts are being left behind.

@khipp khipp force-pushed the eset-cyber-security-use-versioned-url-and-update-livecheck branch from 8e69e3f to 9645813 Compare January 27, 2025 01:46
@khipp khipp force-pushed the eset-cyber-security-use-versioned-url-and-update-livecheck branch from 9645813 to 574c7ac Compare January 27, 2025 02:38
@khipp khipp changed the title eset-cyber-security*: use versioned url and update livecheck eset-cyber-security: use versioned url and update livecheck Jan 27, 2025
@khipp khipp added the ready to merge PR can be merged once CI is green label Jan 27, 2025
@khipp khipp enabled auto-merge January 27, 2025 15:26
@khipp khipp merged commit a7fa632 into Homebrew:master Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants