Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weakauras-companion 5.2.9 #198648

Merged
0 commits merged into from
Jan 17, 2025
Merged

weakauras-companion 5.2.9 #198648

0 commits merged into from
Jan 17, 2025

Conversation

eleanordoesntcode
Copy link
Contributor

@eleanordoesntcode eleanordoesntcode commented Jan 17, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


Note that I updated the required macOS version and I removed the website as it is currently down and has been for the past couple of hours

@bevanjkay bevanjkay closed this pull request by merging all changes into Homebrew:master in fd44dce Jan 17, 2025
@eleanordoesntcode
Copy link
Contributor Author

@bevanjkay it doesn't seem like the file got updated https://github.com/Homebrew/homebrew-cask/blob/master/Casks/w/weakauras-companion.rb, is it normal?

@bevanjkay
Copy link
Member

bevanjkay commented Jan 17, 2025

It looks like the commit was removed by a force push when you synced your fork using the https://github.com/apps/pull app.
This meant the PR had no changes.

Then GitHub automatically closed the PR because the HEAD matched the content of this PR.
I didn't activate a merge or close here.

You'll need to open the PR again.
But you can cherry pick your commit from here if you'd like - 1832a0f

@eleanordoesntcode
Copy link
Contributor Author

ah, understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants