-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lyric-fever 2.0 (new cask) #198572
lyric-fever 2.0 (new cask) #198572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to homebrew-cask
, @aviwad! 🎉
I left a few suggestions below.
Thank you, @aviwad! The filename still has to be updated to |
Have updated the filename. Attempting to squash commits. |
I am very sorry but I really don't know how to squash my commits in this scenario: the main branch commits are showing up in my git terminal. Very sorry. Any help would be appreciated. |
ba1f494
to
ecaf706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aviwad 🎉 - I squashed the commits
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
lyric-fever
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online lyric-fever
is error-free.brew style --fix lyric-fever
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new lyric-fever
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask lyric-fever
worked successfully.brew uninstall --cask lyric-fever
worked successfully.Lyric Fever is my app that displays time-synced lyrics for Spotify and Apple Music in the menubar, with a fullscreen and karaoke mode. Its GitHub project link is https://github.com/aviwad/LyricFever, it's got 164 stars and 200 overall daily users.