Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyric-fever 2.0 (new cask) #198572

Merged
merged 1 commit into from
Jan 17, 2025
Merged

lyric-fever 2.0 (new cask) #198572

merged 1 commit into from
Jan 17, 2025

Conversation

aviwad
Copy link
Contributor

@aviwad aviwad commented Jan 17, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions lyric-fever is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new lyric-fever worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask lyric-fever worked successfully.
  • brew uninstall --cask lyric-fever worked successfully.

Lyric Fever is my app that displays time-synced lyrics for Spotify and Apple Music in the menubar, with a fullscreen and karaoke mode. Its GitHub project link is https://github.com/aviwad/LyricFever, it's got 164 stars and 200 overall daily users.

@aviwad aviwad changed the title Lyric Fever v2.0 Lyric Fever v2.0 (new cask) Jan 17, 2025
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @aviwad! 🎉

I left a few suggestions below.

Casks/l/lyricfever.rb Outdated Show resolved Hide resolved
Casks/l/lyricfever.rb Outdated Show resolved Hide resolved
Casks/l/lyricfever.rb Outdated Show resolved Hide resolved
Casks/l/lyricfever.rb Outdated Show resolved Hide resolved
@khipp khipp changed the title Lyric Fever v2.0 (new cask) lyric-fever 2.0 (new cask) Jan 17, 2025
@khipp
Copy link
Member

khipp commented Jan 17, 2025

Thank you, @aviwad! The filename still has to be updated to lyric-fever.rb. Please also try to squash the commits.

@aviwad
Copy link
Contributor Author

aviwad commented Jan 17, 2025

Have updated the filename. Attempting to squash commits.

@aviwad
Copy link
Contributor Author

aviwad commented Jan 17, 2025

I am very sorry but I really don't know how to squash my commits in this scenario: the main branch commits are showing up in my git terminal. Very sorry. Any help would be appreciated.

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aviwad 🎉 - I squashed the commits

@khipp khipp merged commit b06d034 into Homebrew:master Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants