From 344df2a5d6bb1621125608ae50a7620c03f753bc Mon Sep 17 00:00:00 2001
From: poikilos <7557867+poikilos@users.noreply.github.com>
Date: Thu, 11 Apr 2024 11:16:35 -0400
Subject: [PATCH] Raise exception if base and head are same file. Conform a
 related docstring to Google Style such as for Sphinx.

---
 channeltinkerpil/diffimagesratio.py | 53 ++++++++++++++++++++++-------
 1 file changed, 40 insertions(+), 13 deletions(-)

diff --git a/channeltinkerpil/diffimagesratio.py b/channeltinkerpil/diffimagesratio.py
index 8a4d8fd..3212446 100755
--- a/channeltinkerpil/diffimagesratio.py
+++ b/channeltinkerpil/diffimagesratio.py
@@ -62,19 +62,33 @@ def firstDifferentSubdirs(path1, path2):
 def showDiffRatioForImages(base_path, head_path, root=None, indent="",
                            max_source_ratio=None, skipDirNames=[],
                            patchify=False, oldResults=None):
-    '''
-    This will show images added or where ratio changed (but not images
-    that were removed, because base_path isn't traversed, only checked
-    for existing files and directories parallel to head_path).
-
-    Keyword arguments:
-    root -- This part is always removed from head_path before displaying
-            it.
-    max_source_ratio -- only show items where the source ratio is less
-                        than or equal to this number.
-    skipDirNames -- exclude these directory names.
-
-    When adding new options, pass them onto BOTH recursive calls!
+    '''Show images added or where ratio changed
+    (but not images that were removed, because base_path isn't
+    traversed, only checked for existing files and directories parallel
+    to head_path).
+
+    ^ When adding new args, pass them onto BOTH recursive calls!
+
+    Args:
+        root (str): This part is always removed from head_path before
+            displaying it.
+        max_source_ratio (float): only show items where the source ratio
+            is less than or equal to this number.
+        skipDirNames (list[str]): exclude these directory names.
+        patchify (bool): Write commands to implement the change(s) to
+            results['prepatch_commands'] and/or
+            results['patch_commands'].
+        oldResults (dict): Existing dict for combining results
+            (if not None, used and modified for return).
+
+    Returns:
+        dict: Info about differences, such as:
+            - 'wider_images' (list[str]): paths
+            - 'narrower_images' (list[str]): paths
+            - 'prepatch_commands' (list[str]): preliminary bash commands
+              to merge head
+            - 'patch_commands' (list[str]): final bash commands to merge
+              head
     '''
     if max_source_ratio is not None:
         max_source_ratio = float(max_source_ratio)
@@ -124,12 +138,25 @@ def showDiffRatioForImages(base_path, head_path, root=None, indent="",
             if extLower not in checkDotTypes:
                 continue
             if os.path.isfile(baseSubPath):
+                if (os.path.realpath(baseSubPath)
+                        == os.path.realpath(headSubPath)):
+                    raise ValueError("head and base are same file")
+                # imgResults = None
+                # if os.path.isfile(headSubPath):
                 imgResults = diff_images_by_path(baseSubPath, headSubPath)
+                # else:
+                #     print(indent+"- [ ] doesn't exist: {}"
+                #           .format(headSubPath))
+                # if not imgResults:
+                #     changed = True
+                #     pass
                 if imgResults['head'].get('error') is not None:
                     print(indent+"- [ ] unreadable: {}".format(headSubPath))
+                    # caller should show the real 'error'
                 elif imgResults['base'].get('error') is not None:
                     print(indent+"- [ ] unreadable in previous version: {}"
                           .format(headSubPath))
+                    # caller should show the real 'error'
                 elif imgResults['head']['ratio'] > imgResults['base']['ratio']:
                     if ((max_source_ratio is not None)
                             and (imgResults['base']['ratio']