Non-undoable actions need a confirmation dialog ("tired of this song")

[westonc]

I just misjudged which app had focus, was in Hermes rather than a browser, and went to open a new tab with a keyboard shortcut.

If you know that cmd-T is a shortcut for "I'm tired of this song", you know what happened next. And apparently there's no way to undo that, Pandora just stops playing it for you for some unknown period of time.

Confirmation dialogs are kindof lame (undo is usually a better experience), but given that Pandora doesn't seem to support this in their UI either there may not be any obvious call that can invoke an undo of a "tired" action. And the only other option I can think of would be to emulate "tired" by invoking "skip" and then giving the user some sort of undo button for N seconds and then invoking "tired," which I also don't know if the API would support. So, maybe a confirmation dialog is easiest?

[pmetzger]

You can undo thumbs-down judgements on Pandora so I'm sure there's some way to just add undo.

[nriley]

Seems like there may be several issues here. I agree that non-undoable actions should require confirmation, and also think that potentially we need to change the default keyboard shortcut for Tired. When this was introduced, tabs were not a common feature or a standard one in macOS apps as they are now.

I don't see a Pandora API to reverse "tired of this song" — not that one doesn't exist but I don't think it's been discovered. If you can find another open-source Pandora client that supports this it could be added to Hermes.

Hermes does allow you to reverse a thumbs down decision. You can either do this from the history drawer or from the Edit Station window.

[pmetzger]

I think "thumbs down" might have been what I was thinking of. My mistake.

Maybe just get rid of the keyboard shortcut for tired — it's not such a big deal to need to use the menu.

[nriley]

That would be also fine too — a user can add one from System Preferences if they want. I’ve never used that feature myself.