Fix MLFSIterator, add tests for it #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Iteration is quite slow for now. |
ReubenJ
force-pushed
the
fix/update_mlfi
branch
from
c992b07 to
0a6a044
Compare
ReubenJ
requested changes
Feb 25, 2025
| @@ -42,7 +42,7 @@ Returns a sorted sublist of the `indices`, based on which rules are most promisi | |||
| By default, this is the identity function. | |||
There was a problem hiding this comment.
This is no longer true, correct?
Is this slower as a result of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
MLFSIteratorrequires Herb-AI/HerbGrammar.jl#104 to work.