CompatHelper: bump compat for HerbGrammar to 0.5, (keep existing compat) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 71.26% 71.26%
=======================================
Files 20 20
Lines 689 689
=======================================
Hits 491 491
Misses 198 198 ☔ View full report in Codecov by Sentry. |
Simplify compat for `Random`
THinnerichs
reviewed
Jan 20, 2025
| HerbInterpret = "^0.1.3" | ||
| HerbSpecification = "0.2" | ||
| MLStyle = "^0.4.17" | ||
| Random = "1.8.0,1.9.0,1.10.0,1.11.0" | ||
| Random = "1.8.0" |
There was a problem hiding this comment.
Why not make it ^1.8.0 then? I think Nicolai was using some Random = 1.10 features for a branch (though I am not sure about that anymore).
There was a problem hiding this comment.
"=^1.8" is the same as "=1.8" (the caret is the default behavior) and both allow for packages in the range [1.8, 2.0).
ReubenJ
force-pushed
the
compathelper/new_version/2024-12-13-01-52-34-511-01072321669
branch
from
9f4bcea to
a1f1ca4
Compare
The caret is the default SemVer behavior (https://pkgdocs.julialang.org/v1/compatibility/\#Caret-specifiers) and it seems other projects leave it off.
ReubenJ
force-pushed
the
compathelper/new_version/2024-12-13-01-52-34-511-01072321669
branch
from
a1f1ca4 to
1a23938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
HerbGrammarpackage from^0.4.0to^0.4.0, 0.5.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.