Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MineRL/Probe #108

Merged
merged 6 commits into from
May 28, 2024
Merged

Refactor MineRL/Probe #108

merged 6 commits into from
May 28, 2024

Conversation

eErr0Re
Copy link

@eErr0Re eErr0Re commented May 27, 2024

No description provided.

eErr0Re and others added 5 commits May 25, 2024 15:20
Add nice probe ascii art print.
Move the @isdefined environment check to the getting_started_minerl.jl
Add a fix and a comment such that we know what weng wrong.
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 9.32203% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 61.14%. Comparing base (1f0c97e) to head (05cf1a1).
Report is 1 commits behind head on probe-with-minerl.

Current head 05cf1a1 differs from pull request most recent head 773e617

Please upload reports for the commit 773e617 to get more accurate results.

Files Patch % Lines
src/minecraft/minerl.jl 0.00% 76 Missing ⚠️
src/probe/probe_iterator.jl 15.38% 11 Missing ⚠️
src/probe/select_partial_sols.jl 20.00% 8 Missing ⚠️
src/minecraft/logo_print.jl 0.00% 4 Missing ⚠️
src/probe/program_cache.jl 57.14% 3 Missing ⚠️
src/minecraft/getting_started_minerl.jl 0.00% 2 Missing ⚠️
src/probe/guided_trace_search_iterator.jl 0.00% 2 Missing ⚠️
src/probe/new_program_iterator.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           probe-with-minerl     #108      +/-   ##
=====================================================
+ Coverage              60.56%   61.14%   +0.57%     
=====================================================
  Files                     32       33       +1     
  Lines                   1202     1189      -13     
=====================================================
- Hits                     728      727       -1     
+ Misses                   474      462      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nicolaefilat nicolaefilat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I will replace the println and printstylzed with @debug and @info

@nicolaefilat nicolaefilat merged commit 0bb7e28 into probe-with-minerl May 28, 2024
3 checks passed
@nicolaefilat nicolaefilat deleted the refactor-minerl branch May 31, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants