Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It keeps breaking the download #32

Open
worldsdream opened this issue Mar 18, 2023 · 12 comments
Open

It keeps breaking the download #32

worldsdream opened this issue Mar 18, 2023 · 12 comments

Comments

@worldsdream
Copy link

It shows 6% for the hash ranges download, and the message appears:

Finished downloading all hash ranges in 2,364,478ms (48.52 hashes per second).
We made 114,734 Cloudflare requests (avg response time: 207.52ms). Of those, Cloudflare had already cached 114,732
requests, and made 2 requests to the Have I Been Pwned origin server.

So it looks like it gets corrupted, and the download stops.

The message should now show that it's finished downloading because it's not.

Also, what can be done if you want to download such a big file? We used to have a torrent and that worked perfectly.

The command I run:

haveibeenpwned-downloader.exe -n pwnedpasswords_ntlm

@troyhunt
Copy link
Contributor

The old model definitely wasn't prefect, it became a stuck-in-time frozen version of passwords that never got updates from the firehose of new passwords fed in by the FBI. We're looking into this issue, but you're far better off just consuming the API on demand for password checks rather than downloading the entire corpus of data.

@worldsdream
Copy link
Author

I understand @troyhunt.

If there would be an option in the download to pause/resume or something that it doesn’t break and we have to start all over with the download would be great.

I tried 3x times and I still couldn’t download the file.

With the API is best. But the tool isn’t configured for that.

https://docs.lithnet.io/password-protection/installation/create-a-new-store

Maybe the application will get an update and use the API.

@stebet
Copy link
Contributor

stebet commented Mar 19, 2023

The latest release should be a lot more resilient. Please try updating to 0.3.12.

@worldsdream
Copy link
Author

@stebet Thank you for the very fast update.

I am downloading it and will report what I will get. The internet speed (fiber-optic) is good, and I never have any hiccups.

Let's see if it works well now.

One last thing.

Is there also a command for "NTLM ordered by hash"? I always downloaded that one from "torrent".

Right now, I am running "haveibeenpwned-downloader.exe -n pwnedpasswords_ntlm". But that's not ordered by hash, right?

If so, is there command for it?

Thank you.

@stebet
Copy link
Contributor

stebet commented Mar 20, 2023

Right now, I am running "haveibeenpwned-downloader.exe -n pwnedpasswords_ntlm". But that's not ordered by hash, right?

If so, is there command for it?

Thank you.

That is ordered by hash :)

@worldsdream
Copy link
Author

Thanks @stebet

After running the command, I left it overnight and checked it.

So this is how it looks:

info

At 49% it had an error and stopped.

It looks better with this code update. But unfortunately, not there yet.

@stebet
Copy link
Contributor

stebet commented Mar 20, 2023

Are you running the latest version? There should be richer exception detail.

@stebet
Copy link
Contributor

stebet commented Mar 20, 2023

Also, that looks like it actually finished making all 1.048.576 requests. How big is the resulting file?

@worldsdream
Copy link
Author

I am running version: 0.3.12

The file is 28.5 GB.

It shows that it took 04:03:33 and failed. But, it started again, and within 00:00:00 it got finished (which doesn't make sense).

Let me know if you like me to test anything.

@crypt0rr
Copy link

Currently experiencing the same issue, will try to give it a go tomorrow again.

Running v0.3.12.

@crypt0rr
Copy link

Re-tested today, it finished resulting in a filesize of 36.633.142KB.

haveibeenpwned-downloader

@stebet
Copy link
Contributor

stebet commented May 17, 2023

Re-tested today, it finished resulting in a filesize of 36.633.142KB.

haveibeenpwned-downloader

That seems about right as a final file-size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants