Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Removes unleash from Redux store #589

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

tuliomir
Copy link
Collaborator

The next version of Redux throws an error by default whenever there are non-serializable objects in its Store ( more about this on this article ). This PR is one in a series of PRs that aim to refactor all of those instances before the upgrade.

The unleash Redux property is currently initialized at the start of the application and used as a monitoring tool for dynamic feature activation. The proposed singleton solution is similar to the one on #580 , which was recently merged.

Acceptance Criteria

  • Create an unleash singleton javascript module, apart from the Redux store
  • Refactor all the calls from this store property to use the singleton directly
  • Remove unused code after this change

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Apr 25, 2024
@tuliomir tuliomir removed the request for review from pedroferreira1 April 25, 2024 15:42
@tuliomir tuliomir requested review from alexruzenhack and removed request for r4mmer April 26, 2024 16:57
@tuliomir tuliomir requested a review from andreabadesso April 29, 2024 15:14
@tuliomir tuliomir merged commit 73f64ea into master Apr 29, 2024
1 check passed
@tuliomir tuliomir deleted the chore/unleash-state branch April 29, 2024 18:26
@tuliomir tuliomir mentioned this pull request May 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants