fix: fetchMinRewardBlocks fails when reward_min_blocks is 0 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
approved these changes
Jun 21, 2024
glevco
reviewed
Jun 25, 2024
glevco
approved these changes
Jun 25, 2024
andreabadesso
added a commit
that referenced
this pull request
Dec 9, 2024
* chore: deploy Nano Testnet (#168) * fix: fetchMinRewardBlocks fails when reward_min_blocks is 0 (#177) * fix: handle tx with no inputs and outputs (#178) * chore: added NODE_ENV to integration tests * fix: stop failing when there are no address balance on a transaction * tests: added tests for the voidTransaction method * chore: re-add test_images_down * feat: allow sending alerts to another account (#179) * fix: handle tx with no inputs (#181) * tests: added tests for the voidTransaction method * chore: re-add test_images_down * fix: markUtxosAsVoided should not throw when inputs are empty * fix: returning empty object on db utils and added test for services including db * tests: fix invalid order of calls * tests: missing tests [part 1/2] (#183) * tests: added missing tests * tests: added missing tests for nft push * chore: added docker-compose to flake * tests: ts-ignore -> ts-expect-error * feat: handling the vertex_removed event (#182) * feat: handling the vertex_removed event * fix: handling empty arrays on IN conditions * feat: handling VERTEX_REMOVED event * tests: fix last event * feat: voiding and removing transaction on vertex_removed event * tests: added tests for empty array errors * chore: using port 8085 * chore: actually using 8085 * refactor: removed misleading comment * ci: support sub-accounts (#184) * fix: non-standard scripts (#185) * fix: handling utxos with empty scripts being spent * refactor: helper to roll until an event * chore: using latest :stable on custom and empty script docker compose * refactor: removed unused logs * chore: using fixed dependencies for all projects (#186) * fix: updated balances and network name (#196) * fix: updated throttling lib causing deploy to fail (#195) * fix: updated firebase-admin lib version and deprecated sendMulticast (#194) * fix: updated firebase-admin lib version and deprecated sendMulticast * fix: tests mocking sendMulticast instead of the correct method * fix: slow address generation (#199) * chore: bumped to v1.6.3 (#200) --------- Co-authored-by: Luis Helder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fetchMinRewardBlocksis throwing an error whenreward_min_blocksis 0 on the fullnodeAcceptance Criteria
fetchMinRewardBlocksshould not throw when thereward_min_blocksreturned by the fullnode is 0Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged