Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: using jest fake timers #433

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

andreabadesso
Copy link
Collaborator

@andreabadesso andreabadesso commented Jul 28, 2023

Motivation

Tests are failing on the 1.27.0+beta bump PR because of an off-by-one error when calculating time differences.

Acceptance Criteria

  • We should use jest fake timers to have more control over time on tests

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jul 28, 2023
@andreabadesso andreabadesso added the enhancement New feature or request label Jul 28, 2023
@tuliomir tuliomir removed their request for review December 13, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant