Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash on invalid words #653

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix: Crash on invalid words #653

merged 2 commits into from
Feb 24, 2025

Conversation

tuliomir
Copy link
Contributor

There were two events that triggered the validation of the words on the "Import Wallet" screen:

  • Clicking the "Next" button at the bottom of the screen
  • Clicking the native "Submit" button from the TextArea.

Each of these events had their own validation, which led to inconsistent app behavior and crashes when using the "Submit" button.

Acceptance Criteria

  • In the "Import Wallet" screen, user must not receive an error by clicking "Submit" with an empty text
  • Also must not receive an error with invalid words

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Example interaction

output_480p.mp4

@tuliomir tuliomir added the bug Something isn't working label Feb 14, 2025
@tuliomir tuliomir self-assigned this Feb 14, 2025
@tuliomir tuliomir merged commit 0418802 into master Feb 24, 2025
1 check passed
@tuliomir tuliomir deleted the fix/seed-words-crash branch February 24, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants