Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: current-project to 1.0.1 #497

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

bump: current-project to 1.0.1 #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/HathorMobile.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = HathorMobile/HathorMobile.entitlements;
CURRENT_PROJECT_VERSION = 1.0.0;
CURRENT_PROJECT_VERSION = 1.0.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I'm not sure this would work. The way we use the PROJECT_VERSION property is only by manipulating the major and versions: one for each release candidate version. For example: rc.4 would have a project version 0.4.0.

When we have a stable release we use the 1.0.0.
So in this case the 1.0.1 would have no meaning and should not be used.

My suggestion is that we update the full application to a new patch: v0.27.1. This would revert the CURRENT_PROJECT_VERSION to 1.0.0 as it will be a new stable.

DEVELOPMENT_TEAM = 55SHY647CG;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = HathorMobile/Info.plist;
Expand Down Expand Up @@ -542,7 +542,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = HathorMobile/HathorMobile.entitlements;
CURRENT_PROJECT_VERSION = 1.0.0;
CURRENT_PROJECT_VERSION = 1.0.1;
DEVELOPMENT_TEAM = 55SHY647CG;
INFOPLIST_FILE = HathorMobile/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
Expand Down
Loading