fix: token duplication on dashboard #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
approved these changes
Feb 22, 2024
| * @param {unknown} props.header | ||
| * @param {boolean} props.renderArrow | ||
| * @param {function} props.onItemPress | ||
| */ | ||
| const TokenSelect = (props) => { | ||
| const tokens = Object.values(props.tokens); |
There was a problem hiding this comment.
Suggested change
| const tokens = Object.values(props.tokens); | |
| const tokens = getRegisteredTokenUids(props); |
There was a problem hiding this comment.
He is getting the token objects here. The method getRegisteredTokenUids gets only the uid, if I'm not wrong.
There was a problem hiding this comment.
That's correct, @pedroferreira1. We should stick with the object here, not the uid.
pedroferreira1
approved these changes
Feb 29, 2024
| * @param {unknown} props.header | ||
| * @param {boolean} props.renderArrow | ||
| * @param {function} props.onItemPress | ||
| */ | ||
| const TokenSelect = (props) => { | ||
| const tokens = Object.values(props.tokens); |
There was a problem hiding this comment.
He is getting the token objects here. The method getRegisteredTokenUids gets only the uid, if I'm not wrong.
This was referenced Mar 6, 2024
Merged
This was referenced May 9, 2024
Merged
alexruzenhack
added a commit
that referenced
this pull request
May 15, 2024
* fix: token duplication on dashboard * lint: comply with rules
Closed
alexruzenhack
added a commit
that referenced
this pull request
May 15, 2024
* fix: token duplication on dashboard * lint: comply with rules
alexruzenhack
added a commit
that referenced
this pull request
May 15, 2024
* fix: token duplication on dashboard * lint: comply with rules
alexruzenhack
added a commit
that referenced
this pull request
May 15, 2024
* fix: token duplication on dashboard * lint: comply with rules
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes: https://github.com/HathorNetwork/internal-issues/issues/242
@pedroferreira1 has investigated the these of migration be the culprit and has confirmed it. See the investigation note.
Despite we didn't need a fix anymore, we will proceed to avoid this problem in the future.
Acceptance Criteria
The following recording shows operations with token, register, unregister and creation to demonstrate these operations were not effected by the fix/refactoring:
RocketSim_Recording_iPhone_15_6.1_2024-02-16_14.37.24.mp4
Security Checklist