Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opt-in modal render time #424

Merged
merged 5 commits into from
Feb 13, 2024
Merged

fix: opt-in modal render time #424

merged 5 commits into from
Feb 13, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Feb 2, 2024 •
edited
Loading

Acceptance Criteria

  • fix: push notification opt-in modal render time
  • chore: improve code readability

Opt-in renders after wallet becomes ready:

push-notification-optin.mov

Closes: #416

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Feb 2, 2024
andreabadesso
andreabadesso reviewed Feb 5, 2024
View reviewed changes
@alexruzenhack alexruzenhack merged commit 445164e into master Feb 13, 2024
2 checks passed
@alexruzenhack alexruzenhack mentioned this pull request Feb 13, 2024
Merged
1 task
@alexruzenhack alexruzenhack deleted the fix/opt-in-modal branch February 13, 2024 19:56
@alexruzenhack alexruzenhack mentioned this pull request Mar 8, 2024
Merged
6 tasks
@alexruzenhack alexruzenhack mentioned this pull request May 9, 2024
Merged
alexruzenhack added a commit that referenced this pull request May 15, 2024
@alexruzenhack
fix: opt-in modal render time (#424)
c85535e 
* fix: push notification opt-in modal render time

* chore: improve code readability

* lint: comply with rules and improve comment

* fix: typo

* fix: add delay
alexruzenhack added a commit that referenced this pull request May 15, 2024
@alexruzenhack
fix: opt-in modal render time (#424)
9de4b5a 
* fix: push notification opt-in modal render time

* chore: improve code readability

* lint: comply with rules and improve comment

* fix: typo

* fix: add delay
This was referenced May 15, 2024
Closed
Closed
alexruzenhack added a commit that referenced this pull request May 15, 2024
@alexruzenhack
fix: opt-in modal render time (#424)
0e2c637 
* fix: push notification opt-in modal render time

* chore: improve code readability

* lint: comply with rules and improve comment

* fix: typo

* fix: add delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push Notification pop-up shows before wallet finish loading
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso