Feat: Allow user to close numeric keyboard on iOS #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #402 , the user is unable to close the numeric keyboard on iOS. On some occasions this causes a bad user experience.
This PR fixes this by adding a press event handler on the screens that exhibit a numeric keyboard.
Acceptance Criteria
Tip
In total, just a few lines had actual text modified. The rest of the modified lines were only due to indentation adjustments.
To better visualize the actual changes I suggest using the "Hide whitespace" feature on GitHub, as it highlights only the words that were changed on this file, and not the indentation adjustments that were necessary:
Demonstration
Although the video does not exhibit the finger press locations, it's possible to understand the overall interaction: by pressing anywhere on the screen other than the numeric input, the user is able to close the numeric keyboard.
keyboard.closing.by.input.-.iPhone.13.mini.mp4
Security Checklist