Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicated HTR symbol #654

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: duplicated HTR symbol #654

wants to merge 9 commits into from
+87 −84

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Feb 14, 2025 •
edited
Loading

Acceptance Criteria

  • Removes duplicated "HTR" Symbol from the create token screen
  • Replaces hardcoded "HTR" symbol with the dynamic value for the native token
  • Updates the readme instructions on how to update the translation files

Before and After

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Feb 14, 2025
@tuliomir tuliomir self-assigned this Feb 14, 2025
@tuliomir tuliomir linked an issue Feb 14, 2025 that may be closed by this pull request
Copywriting error during Token Creation Flow #650
Open
@tuliomir tuliomir requested review from r4mmer and removed request for pedroferreira1 February 15, 2025 00:19
r4mmer
r4mmer requested changes Feb 24, 2025
View reviewed changes
src/screens/CreateTokenAmount.js
{jt`You have ${amountAvailableText} HTR available`}
{jt`You have ${amountAvailableText} available`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to line

We should change the amountAvailableText to use the native token symbol we get from the fullnode.
This is because side-dags may use another symbol for the native token.

Copy link
Contributor Author

@tuliomir tuliomir Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on the CreateTokenAmount and CreateTokenConfirm screens in 4eebe07. There are still other instances of hardcoded HTR messages in other places in the code, but those must be fixed in another PR.

Fixed native token

@tuliomir tuliomir requested a review from r4mmer February 26, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabadesso andreabadesso andreabadesso approved these changes

@r4mmer r4mmer Awaiting requested review from r4mmer

Requested changes must be addressed to merge this pull request.

Assignees

@tuliomir tuliomir

Labels
bug Something isn't working
Projects
Hathor Network
Status: In Review (WIP)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copywriting error during Token Creation Flow
3 participants
@tuliomir @andreabadesso @r4mmer