feat: sign oracle data #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
force-pushed
the
feat/sign-oracle-data-2
branch
from
e7d66c6 to
edda8d9
Compare
andreabadesso
force-pushed
the
feat/sign-oracle-data-2
branch
from
167dee2 to
110274f
Compare
andreabadesso
force-pushed
the
feat/sign-oracle-data-2
branch
from
3c71f5e to
186daa2
Compare
andreabadesso
force-pushed
the
feat/sign-oracle-data-2
branch
from
186daa2 to
c6775a6
Compare
andreabadesso
force-pushed
the
feat/sign-oracle-data-2
branch
from
1b65afb to
37fab2c
Compare
andreabadesso
commented
Aug 31, 2024
| @@ -80,7 +80,7 @@ describe('sendNanoContractTx', () => { | |||
|
|
|||
| const result = await sendNanoContractTx(rpcRequest, wallet, {}, promptHandler); | |||
|
|
|||
| expect(promptHandler).toHaveBeenCalledTimes(3); | |||
| expect(promptHandler).toHaveBeenCalledTimes(4); | |||
There was a problem hiding this comment.
LoadingFinished trigger was added and test was not updated
andreabadesso
commented
Aug 31, 2024
Comment on lines
-10
to
-12
| ignores: [ | ||
| 'dist/**/*.js', | ||
| ], |
There was a problem hiding this comment.
Added the ignore on package.json
There was a problem hiding this comment.
question(non-blocking): Is there a specific reason for moving this rule there?
There was a problem hiding this comment.
For some reason eslint was ignoring this, I didn't dive much deeper into figuring out why, so I just moved it to package.json
pedroferreira1
approved these changes
Sep 3, 2024
tuliomir
reviewed
Sep 5, 2024
Comment on lines
-10
to
-12
| ignores: [ | ||
| 'dist/**/*.js', | ||
| ], |
There was a problem hiding this comment.
question(non-blocking): Is there a specific reason for moving this rule there?
tuliomir
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
htr_signOracleDataRPC requestChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged