Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add css linting #361

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Feat: Add css linting #361

merged 2 commits into from
Dec 23, 2024

Conversation

tuliomir
Copy link
Contributor

With the new UI, the complexity of our CSS has increased and we had some hard-to-detect styling errors on our last release process ( see #356 ).

By adding a dedicated lint dependency ( Stylelint ) we increase the automated scrutinity of our code and improve its overall quality.

Acceptance Criteria

  • Adds the Stylelint dependency with its default ruleset of over 100 rules
  • Apply all automated changes from lint:scss:fix

Notes

The final goal of this dependency is to be added to the CI itself. However, it will require many PRs with smaller, peer reviewable changes to reach that point.

Until then, it's the developer responsibility to run the linter before merging the new feature PRs.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Dec 18, 2024
@tuliomir tuliomir self-assigned this Dec 18, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner December 18, 2024 20:54
@tuliomir tuliomir requested review from andreabadesso and removed request for pedroferreira1 December 18, 2024 20:54
@tuliomir tuliomir merged commit 000a6c8 into master Dec 23, 2024
1 check passed
@tuliomir tuliomir deleted the feat/css-lint branch December 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants