Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Invalid opacity value #356

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix: Invalid opacity value #356

merged 2 commits into from
Dec 17, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Dec 17, 2024

Some visual elements were not being displayed. Upon investigation, it was found that the reason was an invalid value of 0px on opacity fields. In development environment this problem did not occur, as the SCSS interpreter was being less strict.

Those elements were removed.

Acceptance Criteria

  • Fixes all instances of visual elements not being displayed
  • Bumps version to patch 0.21.1, as the release process is not fully implemented in this repository chore: rename branches in CI/CD #343

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Dec 17, 2024
@tuliomir tuliomir self-assigned this Dec 17, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner December 17, 2024 22:57
@tuliomir tuliomir merged commit e40a5e0 into release Dec 17, 2024
1 check passed
@tuliomir tuliomir deleted the fix/invalid-opacity branch December 18, 2024 14:37
@tuliomir tuliomir mentioned this pull request Dec 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants