Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error handling on nav search for new UI #352

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Dec 17, 2024

When the user tries to use the search box with the new UI and inputs invalid data ( ex.: an address from another network ), the app throws a javascript error that the ref does not exist.

This was solved by providing an error handler for the Navigation element, with the same fixed positioning as the current UI. Screenshots below for reference.

Acceptance Criteria

  • The correct error message is shown when the search box has invalid content

Warning

The PR indicates there are hundreds of changed lines. This happened because I needed to add one indentation to the Navigation file. To avoid confusion on the review proccess, I recommend activating the Hide Whitespaces feature on the files tab.
That way only the actual changes are displayed, and not the hundreds of indentation changes.

Screenshots

New UI

New UI

Current UI

Current UI

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Dec 17, 2024
@tuliomir tuliomir self-assigned this Dec 17, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner December 17, 2024 00:07
@tuliomir tuliomir merged commit a9fb9ab into master Dec 17, 2024
1 check passed
@tuliomir tuliomir deleted the fix/err-handling-search branch December 17, 2024 15:54
@tuliomir tuliomir mentioned this pull request Jan 16, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants