fix: Error handling on nav search for new UI #352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user tries to use the search box with the new UI and inputs invalid data ( ex.: an address from another network ), the app throws a javascript error that the
ref
does not exist.This was solved by providing an error handler for the Navigation element, with the same fixed positioning as the current UI. Screenshots below for reference.
Acceptance Criteria
Warning
The PR indicates there are hundreds of changed lines. This happened because I needed to add one indentation to the Navigation file. To avoid confusion on the review proccess, I recommend activating the Hide Whitespaces feature on the files tab.
That way only the actual changes are displayed, and not the hundreds of indentation changes.
Screenshots
New UI
Current UI
Security Checklist