Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nft preview unavailable box #351

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix: Nft preview unavailable box #351

merged 2 commits into from
Dec 17, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Dec 16, 2024

In the "Token Details" screen, in the cases where the custom token has a preview, the screen was misaligned. See screenshots below

Acceptance Criteria

  • The current UI should correctly exhibit the screen when it has a preview
  • The new UI should correctly exhibit the "Preview Unavailable" message

Notes

It was not possible to test the correct preview of an NFT for now, as the Explorer Service / Wallet Service are not properly validating all new NFTs created at the time. So, the "content overwrite" feature of Chromium was used to simulate the NFT registration, but without any pictures.

Current UI , before the fix

Current UI Pre-fix

Current UI , after the fix

Current UI Post Fix

New UI, before the fix

New UI Pre Fix

New UI, after the fix

New UI Post Fix

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Dec 16, 2024
@tuliomir tuliomir self-assigned this Dec 16, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner December 16, 2024 20:45
@tuliomir tuliomir merged commit 818dfaf into master Dec 17, 2024
1 check passed
@tuliomir tuliomir deleted the fix/nft-preview-failure branch December 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants