fix: Statistics seconds counter #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4mmer
previously approved these changes
Dec 16, 2024
src/screens/Dashboard.js
Outdated
Comment on lines
44
to
49
| setSummary({ | ||
| bestBlockHeight: heightData.best_block_height, | ||
| transactions: heightData.transactions, | ||
| hashRate: heightData.hash_rate, | ||
| }); | ||
| setTimestamp(new Date(heightData.time * 1000)); |
There was a problem hiding this comment.
Why do you need to set this if you can use the data from redux directly?
I think if you use heightData directly you could remove the whole useEffect.
There was a problem hiding this comment.
As a complement to Pedro's comment, you can track change looking only to the value of best_block_height, not the whole object of heightData.
There was a problem hiding this comment.
Thanks, always good to remove local state from components!
The useEffect was still necessary, as the websocket implementation that provides the height data is not ideal for our needs.
However, the effect now deals exclusively with the time counter data, and not the exhibited values, see 5c6299b.
tuliomir
force-pushed
the
fix/seconds-counter
branch
from
54e2f49 to
5179cab
Compare
alexruzenhack
approved these changes
Jan 2, 2025
r4mmer
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new interface, the timer does not update when the number of txs or the blocks height change. An example of the timer is as follows:
A new version of this screen has changed the counter to the title element, instead of inside each of the realtime boxes, as follows:
Acceptance Criteria
Notes
The current implementation is still not precise, because the
timeproperty of thedashboard:metricswebsocket event received has no relation to the best block or transaction data.This screen should rely on the information received through the websocket as it is now, but the server-side implementation of this event should be changed in the future to provide more precise information here.
Security Checklist